[Mesa-dev] [PATCH 0/2] swrastg: Don't use drm_api

Jakob Bornecrantz wallbraker at gmail.com
Thu Apr 15 10:40:35 PDT 2010


On Thu, Apr 15, 2010 at 6:22 PM, George Sapountzis
<gsapountzis at gmail.com> wrote:
> On Thu, Apr 15, 2010 at 1:31 AM, Jakob Bornecrantz <wallbraker at gmail.com> wrote:
>> Hi George
>>
>> These two patches refactor st/dri and change st/drisw from using drm_api.
>> We do not gain anything from using drm_api and it makes it impossible
>> to define the meaning of struct winsys_handle to something other then
>> what is defined in drm_api.h. I'm working on some changes that needs to
>> do just that, I plan to send them out later this week.
>>
>
> Hi Jakob,
>
> Both patches look good, you can add Reviewed-by if you want.

Cool Thanks!

>
> Wrt to the winsys, keep in mind that swrast has two winsys',
> client-side xlib and the internal xserver api.

Speaking of client, I noticed that the target libgl-xlib is about
twice as fast as dri-swrastg due to it using XShmPutImage instead of
using XPutImage. Maybe it would be a good idea to try and add that to
drisw. Either by using the xlib winsys on the client or defining
winsys_handle and using that to pass down a pre-malloced surface.

Cheers Jakob.


More information about the mesa-dev mailing list