[Mesa-dev] [PATCH 4/4] Fix build with gcc 3.3.

Matthieu Herrb matthieu.herrb at laas.fr
Sun Apr 18 22:34:04 PDT 2010


On Sun, Apr 18, 2010 at 05:03:51PM -0700, Jeremy Huddleston wrote:
> This one looks broken...
> 
> > #if defined(__GNUC__) && ((__GNUC__ == 3 && __GNUC__ >= 4) || __GNUC__ >= 4)
> 
> 
> (__GNUC__ == 3 && __GNUC__ >= 4)
> 
> you forgot _MINOR...
> 
> And I think your '__GNUC_MINOR__ >= 3' might need to be >= 4
> 

Yes, sorry. My first thought was that those builting were gcc 4 only
and I wrote and tested patches with only the __GNUC__ >= 4 test.
Then I found out that gcc 3.4 also have them and quickly modified my tests.
I managed to make one mistake per chunk !.

the commit below to my tree fixes them.



More information about the mesa-dev mailing list