[Mesa-dev] [Bug 29407] llvm 2.8 asserts: "Tried to create an integer operation on a non-integer type!"

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29407

--- Comment #9 from José Fonseca <jfonseca at vmware.com> 2010-08-06 11:37:20 PDT ---
I like the direction of the nobled patches.

But that said, I can only accept the patches when they provoke no regressions
for llvm-2.6, regardless where the fault lies.

It appears the draw module needs two lp_bld_contexts: one for floating point
operations, other for the integer indices operations. It was indeed a
coincidence that things worked so far.

Making the lp_bld_add() automatically detect the incoming variables is *not*
the solution. That would only hide the problems and make it much harder to
debug later, especially because the lp_type is richer than LLVM native vector
types (e.g., fixed point, normalized values etc). Instead, we should add more
asserts like

  assert(lp_check_vec_type(bld->type, a));

to ensure the callers are using consistent types.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.