[Mesa-dev] Mesa (master): translate_generic: return NULL instead of assert(0) if format not supported

José Fonseca jfonseca at vmware.com
Wed Aug 11 08:50:43 PDT 2010


On Wed, 2010-08-11 at 07:59 -0700, Luca Barbieri wrote:
> I assumed that the fact it would crash on a debug build would make the
> behavior safe to change.
> Even if it doesn't crash, it is anyway working incorrectly.

Assert failures mean something that developers didn't anticipate to
happen did happen. But release code should still continue past the
assert and do something sensible like ignoring. That is, it should be
resilient against the unexpected. At least this is my perspective.

> I'll revert it until further notice.

Thanks.

Jose



More information about the mesa-dev mailing list