[Mesa-dev] [Bug 29489] [glsl2] piglit test preprocess-01.frag fails

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 12 10:43:16 PDT 2010


Carl Worth <cworth at cworth.org> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Carl Worth <cworth at cworth.org> 2010-08-12 10:43:15 PDT ---
Thanks, Thomas and Ian for the new test case.

I recently pushed code to the glsl2 branch that fixes this problem.
It's careful to avoid doing any evaluation of an #if or #elif expression
if that expression is skipped entirely, (within an #if/#ifdef/#ifndef/#elif
block evaluated as false), or irrelevant, (subsequent to an expression that
has already evaluated as true).

Below are the headers of the two key commits for the fix.


commit 764e096647ec8c0f20ea3b5191499af806ad23f8
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Aug 11 12:45:55 2010 -0700

    glcpp: Regenerate glcpp-parse.c

    After a recent change to glcpp-parse.y

commit 48ba058e7a4b808271ca987b1553efd7e9792da9
Author: Carl Worth <cworth at cworth.org>
Date:   Wed Aug 11 12:43:44 2010 -0700

    glcpp: Additional fixes for not evaluating skipped #if/#elif expressions.

    This adds a couple of test cases to expand our coverage of invalid #if and
    being skipped, (either by being nested inside an #if/#elif that evaluates
    zero or by being after an #if/#elif that evaluates to non-zero).

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the mesa-dev mailing list