[Mesa-dev] [PATCH 1/3] u_cpu_detect: make arch and little_endian constants, add abi and x86-64

Luca Barbieri luca at luca-barbieri.com
Fri Aug 13 07:15:36 PDT 2010

> #define symbols are usually uppercase.  Is there a reason why you're using
> lowercase?  I'd prefer the code to follow typical conventions.

Currently they can't be used in preprocessor directives because they
evaluate to enums, so it seems better to treat them as variables, and
thus lowercase.

What I think might make sense is to turn them into static consts
rather than making them uppercase and turning the enum into #defines,
since PIPE_ARCH_* (and the more standard __i386__, etc.) can already
be used in preprocessor directives.

More information about the mesa-dev mailing list