[Mesa-dev] [PATCH] draw_llvm: fix segfaults on non-SSE2 CPUs where it is disabled

Zack Rusin zackr at vmware.com
Mon Aug 16 07:19:47 PDT 2010

On Sunday 15 August 2010 01:47:50 Luca Barbieri wrote:
> Currently draw_llvm refuses to create itself on non-SSE2 CPUs due to
> an alleged LLVM bug.
> However, this is implemented improperly, because other parts of draw
> still attempt to access draw->llvm, resulting in segfaults.
> Instead, put the check in debug_get_option_draw_use_llvm, check that
> before calling draw_llvm_create, and then check whether draw->llvm is
> non-null everywhere else.

Thanks Luca, that looks good. debug_get_option_draw_use_llvm would probably be 
better served being called draw_get_option_use_llvm or such since it doesn't 
have that much to do with debug but that's just a nitpick.


More information about the mesa-dev mailing list