[Mesa-dev] [PATCH] gallivm: Fix and re-enable MMX-disabling code

José Fonseca jfonseca at vmware.com
Tue Aug 17 04:24:21 PDT 2010


On Mon, 2010-08-16 at 10:56 -0700, José Fonseca wrote:
> On Mon, 2010-08-16 at 10:30 -0700, nobled wrote:
> > I think this might be the problem that kept -disable-mmx from working;
> > can somebody test it? (attached)
> > ====
> > @@ -152,15 +151,13 @@ lp_set_target_options(void)
> >      * See also:
> >      * - http://llvm.org/bugs/show_bug.cgi?id=3287
> >      * - http://l4.me.uk/post/2009/06/07/llvm-wrinkle-3-configuration-what-configuration/
> > -    *
> > -    * XXX: Unfortunately this is not working.
> >      */
> > -   static boolean first = FALSE;
> > +   static boolean first = TRUE;
> >     if (first) {
> >        static const char* options[] = {
> >           "prog",
> >           "-disable-mmx"
> >        };
> >        llvm::cl::ParseCommandLineOptions(2, const_cast<char**>(options));
> >        first = FALSE;
> >     }
> 
> Lol. Quite likely!

I've tested and it fixed it. For example, doing

  lp_test_format -v -v 2>&1 | grep '%mm[0-9]'

no longer shows any MMX register.

Thanks!

Jose



More information about the mesa-dev mailing list