[Mesa-dev] [PATCH 2/3] mesa: Use the _BaseFormat field to determine attachment completeness.

[Brian Paul]

On 08/26/2010 12:50 PM, Ian Romanick wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Nick Bowler wrote:
>> Intel sometimes uses packed depth/stencil buffers even when only a
>> depth buffer or only a stencil buffer was requested.  GL specifies
>> that GL_DEPTH_COMPONENT renderbuffers are *not* stencil-attachable,
>> but the current check happily attaches these buffers to the stencil
>> attachment point (or vice-versa for GL_STENCIL_INDEX renderbuffers
>> and the depth attachment).  Performing such an attachment must yield
>> an incomplete framebuffer.
>>
>> Since the renderbuffer struct has the actual base format stored in it,
>> use that value instead of recomputing it incorrectly.
>>
>> Signed-off-by: Nick Bowler<nbowler at draconx.ca>
>
> It may not be related (I haven't bisected yet), but at least some
> programs fail with swrast now.  In particular, mandelbrot from Mesa
> demos hits:
>
> mandelbrot: main/depthstencil.c:360: _mesa_new_z24_renderbuffer_wrapper:
> Assertion `dsrb->DataType == 0x84FA' failed.

Hmmm, not seeing that here.

Can you print *dsrb in gdb?

-Brian