[Mesa-dev] [PATCH 0/2] r600g: literals fixes

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Sun Aug 29 02:19:21 PDT 2010


I made two patches to fix problems with literals in the r600g assembler.

The first patch  inserts some r600_bc_add_literal() calls in tgsi_pow(), to ensure that space accounting is done and that the correct values are set. This fixes a segfault and a 
lockup on my computer when using a shader which uses this instruction.

The second patch creates an array of literals and uses the index of the source register to use the right literal, instead of always using the last declared literal. Using realloc on 
each 
declaration probably is not the fastest way, but optimising it would require extra accounting variables. This patch fixes about 20 glsl1 tests from glean on my computer.

Bas Nieuwenhuizen (2):
  r600g: added literals where needed for POW instruction
  r600g: use the values from the correct literals

 src/gallium/drivers/r600/r600_shader.c |   36 ++++++++++++++++++++++++++++---
 1 files changed, 32 insertions(+), 4 deletions(-)



More information about the mesa-dev mailing list