[Mesa-dev] [PATCH 0/2] r600g: literals fixes

Dave Airlie airlied at gmail.com
Sun Aug 29 16:42:30 PDT 2010

On Sun, Aug 29, 2010 at 7:19 PM, Bas Nieuwenhuizen
<bas at basnieuwenhuizen.nl> wrote:
> I made two patches to fix problems with literals in the r600g assembler.
> The first patch  inserts some r600_bc_add_literal() calls in tgsi_pow(), to ensure that space accounting is done and that the correct values are set. This fixes a segfault and a
> lockup on my computer when using a shader which uses this instruction.
> The second patch creates an array of literals and uses the index of the source register to use the right literal, instead of always using the last declared literal. Using realloc on
> each
> declaration probably is not the fastest way, but optimising it would require extra accounting variables. This patch fixes about 20 glsl1 tests from glean on my computer.

Thanks, indeed I get about 25 more piglits with these, pushed to master.


More information about the mesa-dev mailing list