[Mesa-dev] [PATCH] tgsi: fix rbug compile error

Keith Whitwell keithw at vmware.com
Mon Dec 13 04:55:45 PST 2010


On Sat, 2010-12-11 at 04:22 -0800, Jose Fonseca wrote:
> Looks good to me FWIW.
> 
> Usually one uses a union for avoid breaking strict-aliasing rules, but your memcpy approach should produce just as good code with less typing.
> 
> The only proper fix here would be to make struct tgsi_token an union of all possible token types.

Having such a union would have been useful in other cases too...

Keith



More information about the mesa-dev mailing list