[Mesa-dev] [PATCH:mesa-demos] Allow builders to specify GLEW_CFLAGS & GLEW_LIBS

[tom fogal]

Alan Coopersmith <alan.coopersmith at oracle.com> writes:
> configure --help says that builders can set those variables to override
> pkgconfig settings, but configure.ac was overwriting those before calling
> PKG_CHECK_MODULES
> 
> Signed-off-by: Alan Coopersmith <alan.coopersmith at oracle.com>
> ---
>  configure.ac |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index d6753a9..36e42f8 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -81,17 +81,15 @@ AC_CHECK_LIB([glut],
>  		[],
>  		[glut_enabled=no])
>  
> -GLEW_CFLAGS=""
> -GLEW_LIBS="-lGLEW"
>  dnl Include a fallback path for GLEW for the moment while not all distros
>  dnl have picked up the .pc file.
>  PKG_CHECK_MODULES(GLEW, [glew], [], [
>  		  AC_CHECK_HEADER([GL/glew.h],
> -		  [],
> -		  AC_MSG_ERROR([GLEW required]))
> +				  [GLEW_CFLAGS=""],
> +				  AC_MSG_ERROR([GLEW required]))

Isn't this going to mean that GLEW's w/o the .pc file cannot be used?
The .pc is too new for that, IMHO; I think there's only been one
release with it.

Can we just remove the two lines that explicitly set these vars?  Or
maybe remove the cflags one and change the next one to:

  if test "x${GLEW_LIBS}" = "x" ; then
    GLEW_LIBS="-lGLEW"
  fi

or even better:

  GLEW_LIBS=${GLEW_LIBS:="-lGLEW"}

though the latter might be a bashism...

-tom