[Mesa-dev] [PATCH 3/5] pipebuffer: Use pipe_condvar instead of ifdef'd sys_yield()

Keith Whitwell keithw at vmware.com
Mon Jul 5 07:17:35 PDT 2010


On Sat, 2010-07-03 at 13:49 -0700, nobled wrote:
> This way there's fewer ifdef's *and* less busy-waiting.
> ---
>  .../auxiliary/pipebuffer/pb_buffer_fenced.c        |   19 +++++++------------
>  1 files changed, 7 insertions(+), 12 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c
> b/src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c
> index d6cf640..db3617e 100644
> --- a/src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c
> +++ b/src/gallium/auxiliary/pipebuffer/pb_buffer_fenced.c
> @@ -34,13 +34,6 @@
>   */
> 
> 
> -#include "pipe/p_config.h"
> -
> -#if defined(PIPE_OS_LINUX) || defined(PIPE_OS_BSD) || defined(PIPE_OS_SOLARIS)
> -#include <unistd.h>
> -#include <sched.h>
> -#endif
> -
>  #include "pipe/p_compiler.h"
>  #include "pipe/p_defines.h"
>  #include "util/u_debug.h"
> @@ -81,6 +74,7 @@ struct fenced_manager
>      * Following members are mutable and protected by this mutex.
>      */
>     pipe_mutex mutex;
> +   pipe_condvar zero_fenced;
> 
>     /**
>      * Fenced buffer list.
> @@ -307,6 +301,8 @@ fenced_buffer_remove_locked(struct fenced_manager
> *fenced_mgr,
>     LIST_DEL(&fenced_buf->head);

Noble,

It looks like your mail client is word-wrapping these patches, eg.
"*fenced_mgr," above.  Can you figure out a way to send patches without
this -- eg git send-email ?

Keith



More information about the mesa-dev mailing list