[Mesa-dev] [PATCH] dri/r300: test for FEATURE defines

Corbin Simpson mostawesomedude at gmail.com
Tue Jul 13 13:17:42 PDT 2010


On Tue, Jul 13, 2010 at 3:12 AM, Chia-I Wu <olvaffe at gmail.com> wrote:
> On Tue, Jul 13, 2010 at 9:57 AM, nobled <nobled at dreamwidth.org> wrote:
>> Fixes a fatal build error when compiling just OpenGL ES libraries, since
>> FEATURE_EXT_framebuffer_blit is disabled then, so the BlitFramebuffer
>> member doesn't exist.
> Is this change enough to make dri_r300 function as a GLES only driver?
>
> To be honest, I am a little reluctant to sprinkle "#if FEATURE" in the drivers
> at the moment.  The drivers, execept for intel, have not specified GLES api
> support yet.  Even when they do, I would hope there is a more systematic to
> enable/disable certain features, to effectively reduce the driver size.

I'm cool with this, to be honest. GLES support shouldn't be omitted
just because most people aren't going to be using GLES on desktops.

I'll ack this, but I'll wait for a bit in case there are objections to it.

~ C.

-- 
When the facts change, I change my mind. What do you do, sir? ~ Keynes

Corbin Simpson
<MostAwesomeDude at gmail.com>


More information about the mesa-dev mailing list