[Mesa-dev] [PATCH] st/mesa: fix FRAMEBUFFER_UNSUPPORTED with the D24S8 format

Brian Paul brianp at vmware.com
Mon Jul 19 06:49:56 PDT 2010


On 07/19/2010 07:47 AM, Brian Paul wrote:
> On 07/17/2010 02:50 PM, Marek Olšák wrote:
>> Hi,
>>
>> the attached patch attempts to fix bogus reports of
>> GL_FRAMEBUFFER_UNSUPPORTED when there is a D24S8 texture attached as
>> both depth and stencil attachments. The problem is such a renderbuffer
>> is of GL_TEXTURE type which has not been handled properly in
>> st_validate_framebuffer.
>>
>> The r300 classic driver doesn't have this issue, but it affects all
>> Gallium drivers. This feature appears to be mandatory in wine (Bug
>> #29116). I've also added a new piglit test for this: fbo-d24s8.
>>
>> Please review.
>>
>> Best regards.
>>
>> -Marek
>
> Looks good, Marek.  Thanks.

Oh, and this is probably a candidate for the 7.8 branch.

-Brian



More information about the mesa-dev mailing list