[Mesa-dev] [PATCHES] misc. fixes

Jakob Bornecrantz wallbraker at gmail.com
Sun Jul 25 19:57:32 PDT 2010


On Sun, Jul 25, 2010 at 7:30 PM, Vinson Lee <vlee at vmware.com> wrote:
>> -----Original Message-----
>> From: Jakob Bornecrantz [mailto:wallbraker at gmail.com]
>> Subject: Re: [Mesa-dev] [PATCHES] misc. fixes
>>
>> On Sun, Jul 25, 2010 at 3:25 PM, nobled <nobled at dreamwidth.org> wrote:
>>
>> > 4. u_cpu_detect was using PIPE_OS_DARWIN instead of *_APPLE
>>
>> Vinson or some other mac-type person should take a look at this?
>> Especially if PIPE_OS_DARWIN is used somewhere else?
>>
>
> The substitution looks correct.
>
> PIPE_OS_DARWIN is never defined or used elsewhere. The defined macro when on Mac OS is PIPE_OS_APPLE.
>
> The affected code only matters on PowerPC Macs, which I doubt anyone has yet to try.
>

Ok, can I take that as a Acked-by or Reviewed-by ?

Cheers Jakob.


More information about the mesa-dev mailing list