[Mesa-dev] [PATCHES] misc. fixes

[José Fonseca]

On Sun, 2010-07-25 at 19:09 -0700, Jakob Bornecrantz wrote:
> On Sun, Jul 25, 2010 at 3:25 PM, nobled <nobled at dreamwidth.org> wrote:
> > Attached several small patches; review appreciated.
> >
> > 1. i915g: fix llvm build (typo)
> > 2. st/xorg: fix use-after-free
> > 5. fix copy/paste error in the debug output
> 
> These three are
> Acked-by: Jakob Bornecrantz <jakob at vmware.com>
> 
> Do you have commit access? Or should I get these in?
> 
> 
> > 4. u_cpu_detect was using PIPE_OS_DARWIN instead of *_APPLE
> 
> Vinson or some other mac-type person should take a look at this?
> Especially if PIPE_OS_DARWIN is used somewhere else?
> 
> > 3. scons: Allow explicitly selecting MSVC version 10.0
> > 6. scons: wrap abspath to executables in quotes (already an attachment
> > to http://bugs.freedesktop.org/28894)
> > 7. scons/llvm.py: Detect more directory layouts on Windows (LLVM's
> > directory hierarchy compiled with Visual Studio 2010 [and earlier
> > verisons?] is bin/Debug, not Debug/bin, so check for that, too, before
> > failing).
> 
> José can you comment on these 3?

These three look OK by me, as long they don't break other platforms (I
haven't tested).

Jose