[Mesa-dev] [PATCH-v2] gallium: Unified draw_vbo.
Keith Whitwell
keithw at vmware.com
Wed Jul 28 03:24:35 PDT 2010
On Tue, 2010-07-27 at 20:05 -0700, Chia-I Wu wrote:
> On Tue, Jul 27, 2010 at 11:46 PM, Keith Whitwell <keithw at vmware.com> wrote:
> > On Mon, 2010-07-26 at 21:36 -0700, Chia-I Wu wrote:
> >> This is the second try for unified draw_vbo call. I again upload the
> >> patches as a branch here
> >>
> >> http://cgit.freedesktop.org/~olv/mesa/log/?h=gallium-unified-draw-2
> >>
> >> due to the size.
> >>
> >> Changes since v1:
> >>
> >> - make index buffer a state and add pipe_context::set_index_buffer
> >> - there is a boolean in pipe_draw_info controlling whether draw_vbo
> >> should or should not use the index buffer
> >>
> >> Please review.
> >>
> > This is looking good. My only question is what's the easiest way to
> > distinguish between instanced and non-instanced draw_vbo calls?
> Non-instanced draw is equivalent to (start_instance==0 and instance_count==1)
> draw in current form. They are not distinguished. Do the pipe drivers need to
> distinguish them?
No, just showing my ignorance... This looks good to me.
Keith
More information about the mesa-dev
mailing list