[Mesa-dev] [PATCH 1/2] Fix __glXInitializeVisualConfigFromTags's handling of unrecognized fbconfig tags.

Dave Airlie airlied at gmail.com
Sun May 2 02:39:07 PDT 2010


On Fri, Apr 23, 2010 at 2:30 AM, Aaron Plattner <aplattner at nvidia.com> wrote:
> __glXInitializeVisualConfigFromTags doesn't skip the payload of unrecognized
> tags.  Instead, it treats the value as if it were the next tag, which can happen
> if the server's GLX extension is not Mesa's.  For example, this falls down when
> NVIDIA sends a GLX_FLOAT_COMPONENTS_NV = 0 pair, causing
> __glXInitializeVisualConfigFromTags to bail out early.

I've had a regression reported on irc from papillon81 with GLX_USE_GL
and OpenSceneGraph bisected to this.

I'm guessing we need something like the attached.

Dave.

>
> Signed-off-by: Aaron Plattner <aplattner at nvidia.com>
> ---
>  src/glx/glxext.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/src/glx/glxext.c b/src/glx/glxext.c
> index 5289354..6d6f89e 100644
> --- a/src/glx/glxext.c
> +++ b/src/glx/glxext.c
> @@ -539,6 +539,8 @@ __glXInitializeVisualConfigFromTags(__GLcontextModes * config, int count,
>          i = count;
>          break;
>       default:
> +         /* Ignore the unrecognized tag's value */
> +         bp++;
>          break;
>       }
>    }
> --
> 1.6.3.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-glx-fix-regression-with-GLX_USE_GL.patch
Type: application/octet-stream
Size: 698 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100502/af5b8da6/attachment.obj>


More information about the mesa-dev mailing list