[Mesa-dev] [PATCH 2/2] tgsi: make dumping work on non-debug builds

José Fonseca jfonseca at vmware.com
Tue May 4 14:55:43 PDT 2010


On Tue, 2010-05-04 at 14:25 -0700, Marek Olšák wrote:
> ---
>  src/gallium/auxiliary/tgsi/tgsi_dump.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_dump.c b/src/gallium/auxiliary/tgsi/tgsi_dump.c
> index 1ad183b..97b11fb 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_dump.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_dump.c
> @@ -56,7 +56,7 @@ dump_ctx_printf(struct dump_ctx *ctx, const char *format, ...)
>     va_list ap;
>     (void)ctx;
>     va_start(ap, format);
> -   debug_vprintf(format, ap);
> +   vprintf(format, ap);

The right call here is _debug_vprintf().

vprintf is not portable. It is imperative to always use u_string.h and
u_debug.h functions to keep gallium building and working everywhere.

>     va_end(ap);
>  }
>  

Jose



More information about the mesa-dev mailing list