[Mesa-dev] [PATCH] r600g: Only compare active vertex elements

Jerome Glisse j.glisse at gmail.com
Mon Nov 22 17:32:47 PST 2010


On Mon, Nov 22, 2010 at 2:36 PM, Tilman Sauerbeck <tilman at code-monkey.de> wrote:
> Mathias Fröhlich [2010-11-22 19:30]:
>
>> Attached is a patch to r600g which limits the number of compared vertex
>> elements to the amount that is actually active instead of comparing all
>> possible 32 vertex elements.
>> The patch moves the r600_shader_update function down in my usual profile runs.
>>
>> Please review/apply.
>
> Looks good. I wanted to do this change some time ago, but couldn't get
> proof that it actually helped performance-wise.
> Anyway, according to perf it helps with OA.
>
> I'll apply the patch unless Dave or Jerome have objections.
>
> Regards,
> Tilman
>

Patch is fine. Thanks for the work

Cheers,
Jerome


More information about the mesa-dev mailing list