[Mesa-dev] [PATCH] posix_memalign return value check

Brian Paul brianp at vmware.com
Mon Nov 29 08:19:06 PST 2010


On 11/26/2010 05:57 AM, pontus lidman wrote:
> Dear Developers,
>
> I would like to propose the patch below to
> http://cgit.freedesktop.org/mesa/mesa/plain/src/mesa/main/imports.c
>
> The problem: if posix_memalign returns an error (e.g. ENOMEM), the
> function will return an uninitialized value (contents of 'mem'
> pointer) as the allocated address, instead of NULL. In my case this
> lead to segmentation violations later in the program when calling
> other Mesa functions. This happened on linux 2.6.32.

Thanks.  I'm making the change.  BTW, I don't know how you attached 
the patch to your email, but I couldn't extract it; I had to do it by 
hand.

-Brian



More information about the mesa-dev mailing list