[Mesa-dev] Mesa (master): r300/compiler: Move declaration before code.

Ian Romanick idr at freedesktop.org
Sat Oct 2 11:01:49 PDT 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vinson Lee wrote:
> Module: Mesa
> Branch: master
> Commit: 4cd4fd37aa1a68104c80526923f49cd0998779d9
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4cd4fd37aa1a68104c80526923f49cd0998779d9
> 
> Author: Vinson Lee <vlee at vmware.com>
> Date:   Wed Sep 29 13:30:34 2010 -0700
> 
> r300/compiler: Move declaration before code.
> 
> Fixes these GCC warning on linux-x86 build.
> radeon_optimize.c: In function ‘constant_folding’:
> radeon_optimize.c:419: warning: ISO C90 forbids mixed declarations and code
> radeon_optimize.c:425: warning: ISO C90 forbids mixed declarations and code
> radeon_optimize.c:432: warning: ISO C90 forbids mixed declarations and code

Why?  I thought we agreed a couple years ago that core Mesa had to
adhere to C89 rules while DRI driver code could use C99 extensions.

The bigger question is:  Why this code being built in a non-DRI build?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkync4wACgkQX1gOwKyEAw9+SQCfSDL/Mw5KSybWl46MWQ/RvfNq
w0sAni2okk55LNOIrEmEOa9HbPeCnDz/
=xNzu
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list