[Mesa-dev] [PATCH] glsl: Fix ast-to-hir for ARB_fragment_coord_conventions

Ian Romanick idr at freedesktop.org
Mon Oct 25 10:12:10 PDT 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Chad Versace wrote:
> Function ast_declarator_list::hir(), when processing keywords added by
> extension ARB_fragment_coord_conventions, made the mistake of checking only if
> the extension was __supported by the driver__. The correct behavior is to check
> if the extensi0n is __enabled in the parse state__.
> ---
>  src/glsl/ast_to_hir.cpp |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index 15e1afc..4540e98 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
> @@ -2210,7 +2210,7 @@ ast_declarator_list::hir(exec_list *instructions,
>  	    earlier->type = var->type;
>  	    delete var;
>  	    var = NULL;
> -	 } else if (state->extensions->ARB_fragment_coord_conventions
> +	 } else if (state->ARB_fragment_coord_conventions_enable
>  		    && strcmp(var->name, "gl_FragCoord") == 0
>  		    && earlier->type == var->type
>  		    && earlier->mode == var->mode) {

Applied.  Thanks.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzFumgACgkQX1gOwKyEAw+ZHQCgkHo4PxqiD+DqQR2OSuFrHTF2
eOIAn3OTKyyAt2ST0vgrgG29dg5E2NdL
=DExF
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list