[Mesa-dev] [PATCH] fix crash: check for _NumLinkedShaders being 0.

Török Edwin edwintorok at gmail.com
Mon Sep 6 09:47:15 PDT 2010

On Sun, 5 Sep 2010 09:48:22 -0700
Ian Romanick <idr at paranormal-entertainment.com> wrote:

> On Sep 4, 2010, at 3:48 AM, Török Edwin <edwintorok at gmail.com> wrote:
> > From: Török Edvin <edwintorok at gmail.com>
> >
> > Otherwise spring 0.82+.4.0 crashes when starting a game
> > because prog->_LinkedShaders[0] is NULL.
> Any idea what this app is doing to hit this?  A piglit test would be  
> good.

Looks like this occurs when linking a completely empty program.
I wrote a piglit test based on other similar tests (see attached file).

This is first time I write a piglit test, so I'm not sure if this is
the right way to do it, but here is what it does:
$ bin/glsl-emptylink
Segmentation fault

After applying the mesa patch:
$ bin/glsl-emptylink 
PIGLIT: {'result': 'pass' }

Best regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-glsl-empty-link-crash-test.patch
Type: text/x-patch
Size: 3351 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100906/047a5272/attachment.bin>

More information about the mesa-dev mailing list