[Mesa-dev] [Bug 30045] mesa fails to build when configured --disable-driglx-direct

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30045

Kristian Høgsberg <krh at bitplanet.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from Kristian Høgsberg <krh at bitplanet.net> 2010-09-07 09:46:52 PDT ---
(In reply to comment #1)
> Created an attachment (id=38478)
 View: https://bugs.freedesktop.org/attachment.cgi?id=38478
 Review: https://bugs.freedesktop.org/review?bug=30045&attachment=38478

> Some fixes for GLX_INDIRECT_RENDERING only build
> 
> Attached patch fixes some (not all) of GLX_INDIRECT_RENDERING and
> !GLX_DIRECT_RENDERING build issues.
> 
> There still remain some issues with the use of psc->dpy in indirect_glx.c.  I'm
> not sure if changing to use psc->display->dpy is sematically the same.  In
> which case psc->dpy could be removed?

I moved the fields out of the direct-rendering conditional.  Using
psc->display->dpy should work too and eliminating psc->dpy would be less
redundant, but we're trying to release 7.9 in a few weeks, so I'd like to hold
off until then.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.