[Mesa-dev] [PATCHES] multi-api support in st/dri

[Chia-I Wu]

On Wed, Sep 8, 2010 at 12:36 AM, nobled <nobled at dreamwidth.org> wrote:
> The first patch fixes a current bug, the second naively integrates
> support for ES 1 and ES 2 into Gallium DRI drivers:
> 1. st/dri: Make clear which API's are supported (aka just desktop GL)
> 2. st/dri: Add multi-api support (applies after the first patch)
>
> One issue with patch 2, though, is implementing dri_get_current() --
> it calls a vfunc on a struct st_api object, but the st_api object is
> API-specific, and the dri_get_current function is called on a dri
> screen--which could support multiple API's. So for now it has to guess
> which API's implementation of get_current to use -- currently, all
> three use the same implementation, so this isn't a real problem yet.
> Should get_current() be moved out of struct st_api though?
Both patches look good to me.  I will commit them tomorrow.

Instead of moving out get_current(), maybe create_context() should be augmented
to take "enum st_api_type" as an additional argument.

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
>



-- 
olv at LunarG.com