[Mesa-dev] Mesa (master): mesa/st: ask GLSL to not emit noise since we have a dummy implementation

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Luca Barbieri wrote:
> Module: Mesa
> Branch: master
> Commit: fbc7c9b7a9d9df979ea82136d2b74121e5d4346e
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fbc7c9b7a9d9df979ea82136d2b74121e5d4346e
> 
> Author: Luca Barbieri <luca at luca-barbieri.com>
> Date:   Tue Sep 14 05:10:59 2010 +0200
> 
> mesa/st: ask GLSL to not emit noise since we have a dummy implementation

I'm going to "fix" the noise madness pretty quickly after 7.9 ships.  I
have a GLSL implementation of Marc Olano's "GPU noise".  I'm going to
change the lower_noise pass to replace noise opcodes with a call to the
noise function if EmitNoFunctions is not set.

Once that is done, OPCODE_NOISE[1234] and the TGSI noise opcodes can be
removed.

> Note, BTW, that the Gallium implementation returns 0.5, which seems
> to violate the GLSL spec, where it should return 0.0 instead.
> 
> Not sure whether changing it to 0 is correct or not.

Yes.  Returning 0.5 is wrong.  I don't think HLSL has noise, so there
shouldn't be a compatibility issue there.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyPE/0ACgkQX1gOwKyEAw95FACfd1hvKfgC6kzNEFEawuCEvciv
qt8AoIwiLv9qnwZGdwZtJTFEPPAhkdK8
=tr9a
-----END PGP SIGNATURE-----