[Mesa-dev] [PATCH] st/mesa: fix assertion failure in GetTexImage for cubemaps

Brian Paul brian.e.paul at gmail.com
Thu Sep 16 18:10:18 PDT 2010


On Thu, Sep 16, 2010 at 6:49 PM, Marek Olšák <maraeo at gmail.com> wrote:
> Can be reproduced with mesa/demos/src/tests/blitfb.
>
> NOTE: This is a candidate for the 7.9 branch.
> ---
>  src/mesa/state_tracker/st_cb_texture.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c
> index 124cd32..cd50014 100644
> --- a/src/mesa/state_tracker/st_cb_texture.c
> +++ b/src/mesa/state_tracker/st_cb_texture.c
> @@ -240,6 +240,12 @@ get_texture_dims(GLenum target)
>       return 1;
>    case GL_TEXTURE_2D:
>    case GL_TEXTURE_CUBE_MAP_ARB:
> +   case GL_TEXTURE_CUBE_MAP_POSITIVE_X_ARB:
> +   case GL_TEXTURE_CUBE_MAP_NEGATIVE_X_ARB:
> +   case GL_TEXTURE_CUBE_MAP_POSITIVE_Y_ARB:
> +   case GL_TEXTURE_CUBE_MAP_NEGATIVE_Y_ARB:
> +   case GL_TEXTURE_CUBE_MAP_POSITIVE_Z_ARB:
> +   case GL_TEXTURE_CUBE_MAP_NEGATIVE_Z_ARB:
>    case GL_TEXTURE_RECTANGLE_NV:
>    case GL_TEXTURE_2D_ARRAY_EXT:
>       return 2;
> --
> 1.7.0.4

Looks good.

-Brian


More information about the mesa-dev mailing list