[Mesa-dev] [PATCH] tgsi: Actually care what check_soa_dependencies says

José Fonseca jfonseca at vmware.com
Sun Sep 19 00:43:25 PDT 2010

Hi Jakob,

On Sat, 2010-09-18 at 07:30 -0700, Jakob Bornecrantz wrote:
> On Sat, Sep 18, 2010 at 4:26 PM, Jakob Bornecrantz <wallbraker at gmail.com> wrote:
> > Looking over some of the piglit failings that Vinsons have posted running
> > on softpipe (we are down to 3005/3048). At first I was just going to make
> > the output not turn into a warn, but looking at the function it looks like
> > it actually should return the status and fail.
> >
> > This fixes both.

This is a good idea IMO.  

Given the existing of gallivm and tgsi_exec.c, both being pretty
correct, and the former very fast, I'm not sure what use is tgsi_sse2
catering for anymore. So I think that at very least it should not make
things worse.

A few cleanups: MOV is being whilelisted twice -- the second one can be
removed, and the /* XXX: ... */ comment moved to the top of the

> Ops, looks like I ctrl-z the tests this was happening in. Its warning
> on shaders/fp-abs-01 and the ouput is:
> Warning: src/dst aliasing in instruction is not handled:
>   1: COS TEMP[1], TEMP[1].xxxx
> For those who where interested in it.

There are a bunch of opcodes for which tgsi_sse2 actually doesn't trip
over, but are not white-listed yet, like COS.  I went through the code
and added all I could find. 

Also, tgsi_check_soa_dependencies ignores indirect registers.

Patch attached.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: tgsi.diff
Type: text/x-patch
Size: 1823 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100919/ba42625c/attachment.bin>

More information about the mesa-dev mailing list