[Mesa-dev] [PATCH 2/2] i965: Allocate the whole URB to the VS and clarify calculations.

[Kenneth Graunke]

On 04/08/2011 08:32 AM, Ian Romanick wrote:
[snip]
>>      /* CACHE_NEW_VS_PROG */
>> +   /* According to volume 2a, nr_vs_entries must be a multiple of 4 in the
>> +    * range [24, 256] on GT2 and [24, 128] on GT1.
>> +    */
>> +   brw->urb.nr_vs_entries = max_urb_entry;
>>      brw->urb.vs_size = MAX2(brw->vs.prog_data->urb_entry_size, 1);
>
> It occurs to me that this might not work.  Is it possible for
> urb_entry_size * max_urb_entry to be larger than will fit?
>
>      32k / 256 = 128 bytes
>
> On SNB, it looks like the max entry size is (16 attributes + 4 header
> regs) * (16 bytes per entry) = 320 bytes.  Right?

I think you're right.  Spinning a new patch...