[Mesa-dev] [PATCH 0/2] Fix minor issues with GLSL extension usage

Ian Romanick idr at freedesktop.org
Fri Apr 8 17:48:41 PDT 2011


The first patch fixes a problem where a shader could enable
GL_ARB_draw_instanced on a driver that does not support it.  The second patch
reformats the GL_ARB_shader_stencil_export enable block to look more like the
other extension enable blocks.

The set of GLSL extension is getting quite long (9).  Soon, if not now, we
should refactor this code to be table driven.  That should prevent errors like
the one fixed by the first patch.  I'd like to solicit input (or volunteers)
on what that table drive code should look like.

Before I commit these patches, I'd like for someone to test them on a driver
that supports GL_ARB_draw_instanced.  I want some assurance that these changes
don't cause regressions there.

 src/glsl/glsl_parser_extras.cpp |   25 ++++++++++++-------------
 1 files changed, 12 insertions(+), 13 deletions(-)



More information about the mesa-dev mailing list