[Mesa-dev] [PATCH] i965: Allocate the whole URB to the VS and fix calculations for Gen6.

Eric Anholt eric at anholt.net
Wed Apr 13 09:11:46 PDT 2011


On Tue, 12 Apr 2011 15:42:06 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Since we never enable the GS on Sandybridge, there's no need to allocate
> it any URB space.
> 
> Furthermore, the previous calculation was incorrect: it neglected to
> multiply by nr_vs_entries, instead comparing whether twice the size of
> a single VS URB entry was bigger than the entire URB space.  It also
> neglected to take into account that vs_size is in units of 128 byte
> blocks, while urb_size is in bytes.
> 
> Despite the above problems, the calculations resulted in an acceptable
> programming of the URB in most cases, at least on GT2.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

The logic all looks good to me.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110413/d4fd74b1/attachment.pgp>


More information about the mesa-dev mailing list