[Mesa-dev] [PATCH] mesa: Fix _mesa_unpack_dudv_span_byte assertion.

Eric Anholt eric at anholt.net
Wed Apr 13 18:05:09 PDT 2011


It was accepting only GL_DUDV_ATI and not the specific sized format
GL_DU8DV8_ATI.  Fixes assertion failure at startup in Shadowgrounds.
---

Have these assertions in texstore stuff actually proven useful to
people?  So far it seems like I'm always just adding more entries to
them because they never have enough, and any time I want to use this
pack/unpack stuff I'm just reading the code anyway since I know the
assertions don't match reality.

 src/mesa/main/pack.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c
index 0215458..4bb0a90 100644
--- a/src/mesa/main/pack.c
+++ b/src/mesa/main/pack.c
@@ -3973,7 +3973,8 @@ _mesa_unpack_dudv_span_byte( struct gl_context *ctx,
                              GLbitfield transferOps )
 {
    ASSERT(dstFormat == GL_DUDV_ATI);
-   ASSERT(srcFormat == GL_DUDV_ATI);
+   ASSERT(srcFormat == GL_DUDV_ATI ||
+	  srcFormat == GL_DU8DV8_ATI);
 
    ASSERT(srcType == GL_UNSIGNED_BYTE ||
           srcType == GL_BYTE ||
-- 
1.7.4.1



More information about the mesa-dev mailing list