[Mesa-dev] [PATCH] RV730 support for Big Endian platforms

[Alex Deucher]

On Tue, Apr 19, 2011 at 1:24 PM, Henri Verbeet <hverbeet at gmail.com> wrote:
> On 19 April 2011 18:11, Alex Deucher <alexdeucher at gmail.com> wrote:
>> I've pushed the r600c patch.  I'll take a look at the r600g patch later today.
>>
> I'm without r600 hardware this week, but personally I think I'd be
> happier with a helper function for the endian swap, instead of
> sprinkling ifdefs all over the source code.

Yeah, that would probably be nicer.  I'm not inclined to put more
effort into r600c.  It might be a useful cleanup for r600g, but I'm
not sure it would make that much difference since the r600g code is
already pretty clean.

Alex

>
> E.g., something along these lines:
>
> static inline unsigned r600_endian_swap(unsigned size)
> {
> #ifdef PIPE_ARCH_BIG_ENDIAN
>    switch (size)
>    {
>        case 16:
>            return ENDIAN_8IN16;
>        case 32:
>            return ENDIAN_8IN32;
>        case 64:
>            return ENDIAN_8IN64;
>        default:
>            return ENDIAN_NONE;
>    }
> #else
>    return ENDIAN_NONE;
> #endif
> }
>