[Mesa-dev] [PATCH 0/3] Gallium: CopyBufferSubData basic accel

Jakob Bornecrantz wallbraker at gmail.com
Thu Apr 21 05:53:59 PDT 2011


On Thu, Apr 21, 2011 at 2:47 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Thu, Apr 21, 2011 at 1:19 PM, Jakob Bornecrantz <wallbraker at gmail.com>
> wrote:
>>
>> On Thu, Apr 21, 2011 at 1:11 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> > Hi,
>> >
>> > This little series implements CopyBufferSubData via resource_copy_region
>> > and adds a fallback implementation to all drivers. Now drivers can implement
>> > a fast path for CopyBufferSubData instead of always defaulting to the
>> > software path.
>> >
>> > I have tested this series with glean/bufferObject on r600g, softpipe,
>> > and llvmpipe. Please review.
>>
>> I'm assuming that it is not allowed to copy_region between buffers and
>> none buffers? Maybe some asserts to that effect?
>
> In util_resource_copy_region? Or in all the drivers? Or just Galahad?

util_resource_copy_region and Galahad, drivers are free to assert if
they want to but its not something you need to add.

Cheers Jakob.


More information about the mesa-dev mailing list