[Mesa-dev] [PATCH 2/5] mesa: Don't assert on the compressed convertformat for GenerateMipmaps.

[Eric Anholt]

On Wed, 20 Apr 2011 16:20:20 -0700, Ian Romanick <idr at freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 04/20/2011 11:08 AM, Eric Anholt wrote:
> > This assertion doesn't make any sense to me -- the convertFormat is
> > already something valid (tested above), and the BaseFormat dictated by
> > convertFormat doesn't matter to the function about to be called (it's
> > the datatype/comps that were pulled out of convertFormat).
> 
> This is because, without the 2-channel formats, all of the compressed
> formats were either GL_RGB or GL_RGBA.  The data that convertFormat
> describes in this case is the new mipmap created from the (decompressed)
> compressed base level.  The assertion was intended to catch cases that
> would have caused errors in the call to _mesa_texstore (maybe?).
> 
> There are still a limited set of internal formats that can be
> compressed.  I feel like the assertion should be moved out of the
> if-statement, and it should be changed to 'assert(srcImage->TexFormat ==
> dstImage->TexFormat);'

srcImage->TexFormat is passed to
_mesa_init_teximage_fields(..., dstImage, ..., srcImage->TexFormat)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110421/032ea8a9/attachment.pgp>