[Mesa-dev] [PATCH 2/2] configure.ac: refuse to build r300g without LLVM

[Marek Olšák]

Would the attached patch be ok with you? Or do you have a better idea?

Marek

On Thu, Apr 28, 2011 at 11:29 AM, Jon TURNEY
<jon.turney at dronecode.org.uk> wrote:
>
> On 23/04/2011 09:48, Marek Olšák wrote:
> > On Fri, Apr 22, 2011 at 1:29 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
> >
> >> The Mesa state tracker uses SWTNL for GL selection/feedback regardless of
> >> the driver. Some SPECviewperf viewsets and CAD apps use it. So using LLVM
> >> speeds up selection/feedback for all gallium drivers.
> >>
> >> We have only tested LLVM with x86/x86_64. So indeed, using it/requiring it
> >> on other platforms is not advisable.
> >>
> >
> > I take the first patch back. Here's an updated r300g patch that requires
> > LLVM on x86 and x86_64 only:
> >
> >
> >     configure.ac: require LLVM to build r300g on x86 and x86_64
> >
> > diff --git a/configure.ac b/configure.ac
> > index d8c50ce..1012ca5 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -1780,9 +1780,16 @@ dnl Gallium Radeon r300g configuration
> >  dnl
> >  AC_ARG_ENABLE([gallium-r300],
> >      [AS_HELP_STRING([--enable-gallium-r300],
> > -        [build gallium r300 @<:@default=DRI-only@:>@])],
> > +        [build gallium r300 @<:@default=build DRI driver only@:>@])],
> >      [enable_gallium_r300="$enableval"],
> >      [enable_gallium_r300=auto])
> > +if test "x$enable_gallium_r300" != xno; then
> > +    if test "x$MESA_LLVM" = x0; then
> > +        case "$host_cpu" in
> > +        i*86|x86_64) AC_MSG_ERROR([LLVM is required to build Gallium R300
> > on x86 and x86_64]);;
> > +        esac
> > +    fi
> > +fi
> >  if test "x$enable_gallium_r300" = xauto; then
> >      GALLIUM_DRIVERS_DIRS="$GALLIUM_DRIVERS_DIRS r300"
> >      gallium_check_st "radeon/drm" "dri-r300"
>
> This error is triggering in the default (--with-driver=xlib) configuration on
> cygwin, see [1].
>
> [1] http://tinderbox.freedesktop.org/builds/2011-04-27-0005/logs/libGL/#configure
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-configure.ac-do-not-build-r300g-by-default-on-non-Li.patch
Type: text/x-diff
Size: 1010 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110428/e5f747d0/attachment-0001.patch>