[Mesa-dev] [PATCH 2/2] configure.ac: refuse to build r300g without LLVM

[Marek Olšák]

Looks good.

Reviewed-by: Marek Olšák <maraeo at gmail.com>

On Fri, Apr 29, 2011 at 1:55 PM, Jon TURNEY <jon.turney at dronecode.org.uk> wrote:
> On 28/04/2011 11:50, Marek Olšák wrote:
>> Would the attached patch be ok with you? Or do you have a better idea?
>
> I'm wondering if it makes any sense to build the various gallium hardware
> drivers when not ./configured --with-driver=dri? (at the moment svga i915 i965
> r300 are all automatically enabled) Does it make sense to build gallium at
> all? (yes for --with-driver=xlib because we might want to use swrastg, but not
> for --with-driver=osmesa?)
>
> Attached patch makes --disable-gallium-r300 the default if not --with-driver=dri
>
>> On Thu, Apr 28, 2011 at 11:29 AM, Jon TURNEY
>> <jon.turney at dronecode.org.uk> wrote:
>>>
>>> On 23/04/2011 09:48, Marek Olšák wrote:
>>>> On Fri, Apr 22, 2011 at 1:29 PM, Jose Fonseca <jfonseca at vmware.com> wrote:
>>>>
>>>>> The Mesa state tracker uses SWTNL for GL selection/feedback regardless of
>>>>> the driver. Some SPECviewperf viewsets and CAD apps use it. So using LLVM
>>>>> speeds up selection/feedback for all gallium drivers.
>>>>>
>>>>> We have only tested LLVM with x86/x86_64. So indeed, using it/requiring it
>>>>> on other platforms is not advisable.
>>>>>
>>>>
>>>> I take the first patch back. Here's an updated r300g patch that requires
>>>> LLVM on x86 and x86_64 only:
>>>>
>>>>
>>>>     configure.ac: require LLVM to build r300g on x86 and x86_64
>>>>
>>>> diff --git a/configure.ac b/configure.ac
>>>> index d8c50ce..1012ca5 100644
>>>> --- a/configure.ac
>>>> +++ b/configure.ac
>>>> @@ -1780,9 +1780,16 @@ dnl Gallium Radeon r300g configuration
>>>>  dnl
>>>>  AC_ARG_ENABLE([gallium-r300],
>>>>      [AS_HELP_STRING([--enable-gallium-r300],
>>>> -        [build gallium r300 @<:@default=DRI-only@:>@])],
>>>> +        [build gallium r300 @<:@default=build DRI driver only@:>@])],
>>>>      [enable_gallium_r300="$enableval"],
>>>>      [enable_gallium_r300=auto])
>>>> +if test "x$enable_gallium_r300" != xno; then
>>>> +    if test "x$MESA_LLVM" = x0; then
>>>> +        case "$host_cpu" in
>>>> +        i*86|x86_64) AC_MSG_ERROR([LLVM is required to build Gallium R300
>>>> on x86 and x86_64]);;
>>>> +        esac
>>>> +    fi
>>>> +fi
>>>>  if test "x$enable_gallium_r300" = xauto; then
>>>>      GALLIUM_DRIVERS_DIRS="$GALLIUM_DRIVERS_DIRS r300"
>>>>      gallium_check_st "radeon/drm" "dri-r300"
>>>
>>> This error is triggering in the default (--with-driver=xlib) configuration on
>>> cygwin, see [1].
>>>
>>> [1] http://tinderbox.freedesktop.org/builds/2011-04-27-0005/logs/libGL/#configure
>