[Mesa-dev] [PATCH 4/6] vbo: remove unreachable _mesa_error() call

[Jose Fonseca]

Brian,

The series looks good.

BTW, this just remind be of one thing I noticed looking at coverity results before is that it is almost impossible to get zero warnings everywhere. For example, gcc complains that a variable may be used unitialized (when often it cannot), and setting an initial value causes coverity (with its mightier brains) to warn that initial value is never used.  Quite annoying.

Jose

----- Original Message -----
> If mode is not GL_POINT/LINE/FILL we'll have already reported the
> error earlier in the function and returned so we can never get here.
> ---
>  src/mesa/vbo/vbo_exec_api.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/src/mesa/vbo/vbo_exec_api.c
> b/src/mesa/vbo/vbo_exec_api.c
> index 70551e0..4be0169 100644
> --- a/src/mesa/vbo/vbo_exec_api.c
> +++ b/src/mesa/vbo/vbo_exec_api.c
> @@ -655,9 +655,6 @@ vbo_exec_EvalMesh2(GLenum mode, GLint i1, GLint
> i2, GLint j1, GLint j2)
>  	 CALL_End(GET_DISPATCH(), ());
>        }
>        break;
> -   default:
> -      _mesa_error( ctx, GL_INVALID_ENUM, "glEvalMesh2(mode)" );
> -      return;
>     }
>  }
>  
> --
> 1.7.3.4
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>