[Mesa-dev] [PATCH 02/10] i965 gs: Reduce information in key to avoid unnecessary recompiles.

Eric Anholt eric at anholt.net
Mon Dec 5 14:53:19 PST 2011


On Mon,  5 Dec 2011 09:40:45 -0800, Paul Berry <stereotype441 at gmail.com> wrote:
> Previously, the geometry shader program key was storing all the
> information necessary to compute the exact structure of the VUE map
> (attrs and userclip_active).  However, the GS program doesn't depend
> on the exact structure of the VUE map; only on the size (in 256-bit
> registers) of the VUE.  So we were recompiling the GS program
> unnecessarily when the VUE map changed in structure but not in size.
> 
> This patch changes the key to store just the size of the VUE map, not
> its structure.

Hmm.  I'm betting that brw_compute_vue_map() is way more expensive than
the extra couple bytes of key data to compare.

What I really want is to compute the vue map at the top of the pipeline
and reuse it from the various places that want it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111205/9fbbda91/attachment.pgp>


More information about the mesa-dev mailing list