[Mesa-dev] [PATCH 3/6] swrast: software renderbuffer code extracted from main

Eric Anholt eric at anholt.net
Mon Dec 5 15:20:15 PST 2011


On Sun,  4 Dec 2011 20:38:27 -0700, Brian Paul <brianp at vmware.com> wrote:
> Most of main/renderbuffer.c was for allocating and accessing software-
> based renderbuffers.  That code is only used for software rendering so
> move it to swrast.
> 
> The code isn't used at this point yet.  The next patch does the switch-over.

So, this kind of code motion is hard to review.  I'd have to go apply
the diff and manually diff the two files.  I think the mode of handling
it I've seen that I prefer review-wise is copy the file in one commit,
then cut out the bits we don't want and rename functions as it gets
hooked up to the build after that.

(The set of functions moved look good, though)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111205/b06e4791/attachment.pgp>


More information about the mesa-dev mailing list