[Mesa-dev] [PATCH 03/12] intel: Make mapping of texture slices track the region of interest.

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/05/2011 11:42 AM, Eric Anholt wrote:
> This will be used for things like packed depth/stencil temporaries and
> making LLC-cached temporary mappings using blits.
> ---
>  src/mesa/drivers/dri/intel/intel_mipmap_tree.c |   37 ++++++++++++++++++++---
>  src/mesa/drivers/dri/intel/intel_mipmap_tree.h |   18 +++++++++++
>  2 files changed, 50 insertions(+), 5 deletions(-)
> 

> @@ -110,6 +123,11 @@ struct intel_mipmap_level
>        GLuint x_offset;
>        GLuint y_offset;
>        /** \} */
> +
> +      /* Pointer to mapping information, present across
> +       * intel_tex_image_map()/unmap of the slice.
> +       */
> +      struct intel_miptree_map *map;
>     } *slice;
>  };

This comment needs doxygenation.

Otherwise, looks good.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO3mJRAAoJEAIvNt057x8i/GUQAIAB8zev2DBffXSs+1YQ7bFa
xt4SJwZa1gO9b6rTsypqGejCYotC/E9Ja4inOkIhr1rJgrq7C3PqXTfRlDJGS1y4
AqF/u9pytyZI+XV7khPXROxaF1/bSZjazcsaZuQeSVCwcT09CC/nLHmqiJeW2YHH
wGbXNF2K8hp7VA02eHSAMVczp0ANrHR5bFDZF/HJxXN02jWinw2oBTwjHov4PuX3
THzAqpW/scvCWo9wLaBPbHe6gKvzr4jJAdPF2/Q6O2SukiEx/jwO8+XNilQeGVzY
mgjaRCv0GwPj3pzRRmBn+0BLEIii7Xahu+ccaWlhF951YsHbnIERQetBlOthct9Y
NjNAeE5TwB8hM0htmMI9M58WHvgWXYVE4ElBFNoKUSszix+wVsFoYuhmc1EerBIF
GefJ9+PfOoxZHs7E2bsS/ZHew77r/UB5TuTVa/uy4FWK6My7yFCtdOhlhOYhfeBy
u6A43dwcsq7newjBmbyeHhNcuLzCiXIf+ooGcCvojnoWmNSLik5uZQxX18l7XQ5+
92auXMLmwyMv6olmaqsluJ+KngVjM185mnbPC82KrXIbOSvG9nTHtTHvuY1pdgPB
slh0rND3/qCjAiw/gU7hAGrzyJlqFVR0NzgSFyQdXgyCQKwGyGXNcENJ0sA5AtY2
6kXu3D3lphiAiE7zsnA4
=UKX3
-----END PGP SIGNATURE-----