[Mesa-dev] [PATCH 2/6] vl: Get rid of video_buffer.sampler_view_components

[Maarten Lankhorst]

Hey Andy,

On 12/07/2011 05:37 PM, Andy Furniss wrote:
> Maarten Lankhorst wrote:
>> Hey Andy,
>>
>> On 12/06/2011 10:45 PM, Andy Furniss wrote:
>>> Maarten Lankhorst wrote:
>>>> No point in having it when just having sampler_view_planes is good enough. :-)
>>>
>>> This patch causes R600 xvmc to render incorrect chroma for me.
>>>
>> Thanks for testing! I plugged in my r600 and confirmed the bug and
>> fixed it. vl_mc_render_ref was incorrect for CbCr after the change.
>> The incremental diff is attached, but I'll resend this patch.
>
> I tried with the incremental and the chroma corruption is worse.
Oh seems you're right.. how did that patch even work for me on r600? That's insane..

ureg_MOV's ureg_writemask should be fragment, while the argument ureg_src should be color