[Mesa-dev] [PATCH] glx: block attempt to swapbuffer on pixmap. (v2)

[Eric Anholt]

On Wed,  7 Dec 2011 10:24:09 +0000, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
> 
> This keeps track of the creation process and stores a drawable type,
> it then blocks DRI2 from getting called if the drawable is a pixmap.
> 
> v2: check if we have a GLX drawable, which means we aren't a pbuffer,
> avoid doing flush at all since its meant to be a no-op.

I still think this is the wrong way to go.  As ajax pointed out, there's
all sorts of races available from trying to guess client-side, and
there's no way anybody's relying on the current ("print an error message
in the xorg log") behavior of the DRI2 protocol for single-buffered, so
we might as well resolve that DRI2 protocol should do what we want for
GLX.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111207/fdcc4de0/attachment.pgp>