[Mesa-dev] [PATCH 5/6] vl: Remove most members of pipe_video_decoder

[Andy Furniss]

Maarten Lankhorst wrote:

> You might want to check with valgrind to see if it tosses any warning, too.

I tried valgrind and it does seem that r600 is leaking - below is from a 
vanilla mesa with a working test stream and vdpau, xvmc leaks half as 
much with the same stream. In the patched/crashing case the error info 
looked the same as gdb.


<snip> lots of others - all the definitely were like these -

==6549== 7,056 (960 direct, 6,096 indirect) bytes in 12 blocks are 
definitely lost in loss record 314 of 320
==6549==    at 0x40222FD: calloc (vg_replace_malloc.c:566)
==6549==    by 0x5E909EA: r600_create_sampler_view (r600_state.c:1078)
==6549==    by 0x5F10AE7: vl_video_buffer_sampler_view_planes 
(vl_video_buffer.c:139)
==6549==    by 0x5EE4F8C: vl_mpeg12_create_buffer (vl_mpeg12_decoder.c:168)
==6549==    by 0x5E851F3: vlVdpDecoderCreate (decode.c:113)
==6549==    by 0x80F867C: create_vdp_decoder (vo_vdpau.c:598)
==6549==    by 0x80FA23D: control (vo_vdpau.c:1115)
==6549==    by 0x81763E3: query_format (vf_vo.c:145)
==6549==    by 0x8147E8B: mpcodecs_config_vo (vd.c:195)
==6549==    by 0x8215CA2: init_vo (vd_ffmpeg.c:519)
==6549==    by 0x8217699: get_format (vd_ffmpeg.c:953)
==6549==    by 0x858CA6C: mpeg_get_pixelformat (mpeg12.c:1221)
==6549==
==6549== 7,056 (960 direct, 6,096 indirect) bytes in 12 blocks are 
definitely lost in loss record 315 of 320
==6549==    at 0x40222FD: calloc (vg_replace_malloc.c:566)
==6549==    by 0x5E909EA: r600_create_sampler_view (r600_state.c:1078)
==6549==    by 0x5F10AE7: vl_video_buffer_sampler_view_planes 
(vl_video_buffer.c:139)
==6549==    by 0x5EE4FA2: vl_mpeg12_create_buffer (vl_mpeg12_decoder.c:172)
==6549==    by 0x5E851F3: vlVdpDecoderCreate (decode.c:113)
==6549==    by 0x80F867C: create_vdp_decoder (vo_vdpau.c:598)
==6549==    by 0x80FA23D: control (vo_vdpau.c:1115)
==6549==    by 0x81763E3: query_format (vf_vo.c:145)
==6549==    by 0x8147E8B: mpcodecs_config_vo (vd.c:195)
==6549==    by 0x8215CA2: init_vo (vd_ffmpeg.c:519)
==6549==    by 0x8217699: get_format (vd_ffmpeg.c:953)
==6549==    by 0x858CA6C: mpeg_get_pixelformat (mpeg12.c:1221)
==6549==
==6549== 7,680 bytes in 192 blocks are definitely lost in loss record 
316 of 320
==6549==    at 0x40222FD: calloc (vg_replace_malloc.c:566)
==6549==    by 0x5E93437: r600_create_surface (r600_texture.c:510)
==6549==    by 0x5EF11A3: vl_idct_init_buffer (vl_idct.c:646)
==6549==    by 0x5EE5003: vl_mpeg12_create_buffer (vl_mpeg12_decoder.c:177)
==6549==    by 0x5E851F3: vlVdpDecoderCreate (decode.c:113)
==6549==    by 0x80F867C: create_vdp_decoder (vo_vdpau.c:598)
==6549==    by 0x80FA23D: control (vo_vdpau.c:1115)
==6549==    by 0x81763E3: query_format (vf_vo.c:145)
==6549==    by 0x8147E8B: mpcodecs_config_vo (vd.c:195)
==6549==    by 0x8215CA2: init_vo (vd_ffmpeg.c:519)
==6549==    by 0x8217699: get_format (vd_ffmpeg.c:953)
==6549==    by 0x858CA6C: mpeg_get_pixelformat (mpeg12.c:1221)
==6549==
==6549== LEAK SUMMARY:
==6549==    definitely lost: 16,963 bytes in 373 blocks
==6549==    indirectly lost: 23,876 bytes in 94 blocks
==6549==      possibly lost: 25,753 bytes in 1,367 blocks
==6549==    still reachable: 1,174,744 bytes in 1,678 blocks
==6549==         suppressed: 0 bytes in 0 blocks
==6549== Reachable blocks (those to which a pointer was found) are not 
shown.