[Mesa-dev] [PATCH 2/6 v3] g3dvl: Get rid of video_buffer.sampler_view_components

[Maarten Lankhorst]

Hey Andy,

On 12/08/2011 01:24 PM, Andy Furniss wrote:
> Maarten Lankhorst wrote:
>> No point in having it when just having sampler_view_planes is good enough.
>>
>> Signed-off-by: Maarten Lankhorst<m.b.lankhorst at gmail.com>
>>
>> ---
>> Changes since v2:
>> - fixed borked ureg_MOV, I have no idea how it worked when I tested this
>>    on r600 to begin with, it renders correctly now with XvMC acceleration
>>    for softpipe and llvmpipe, with MOCOMP. IDCT still seems to be broken,
>>    but that was the case before this patch, too.
>> - TGSI_WRITEMASK_Y|TGSI_WRITEMASK_Z ->  TGSI_WRITEMASK_YZ
>>
>> Changes since v1:
>> - increase nouveau_video_buffer sampler_view_planes array size to 3,
>>    which is the only valid size, since all planes are tested against null
>> - Fixed vl_mc_render_ref
>
> This is working OK (as before) for me.
>
> Softpipe is working, that's handy - last time I tried it was too borked to be of use, but now I can actually see which errors are software and which are added by R600.
>
My observation for softpipe working correctly only seems to apply for XVMC_MOCOMP,
if I try with XVMC_IDCT set in my xf86 driver it'll fail. Same for XvMC + llvmpipe..

~Maarten