[Mesa-dev] [PATCH] glsl_to_tgsi: make sure copied instructions don't lose texture target.

[Dave Airlie]

>>
>> The piglit draw-pixel-with-texture was asserting in the glsl->tgsi code,
>> due to 0 texture target, this makes sure the texture target is copied over
>> correctly when we copy instructions around.
>
> Oh so it looks like this could be "fun" or maybe the other one, so
> glsl->tgsi is broken for draw pixels where a texturing is enabled.
>
> The problem is we ignore the fact that texturing is enabled and we
> blindly write over the original programs texture info, we also seem to
> bind our samplers on top of the original states which also seems
> doomed to failure.
>
> I'm not 100% sure how best to solve this, I'll just tool around until
> I have an answer unless someone comes up with a better one.

Okay I suspect the st_cb_drawpixels.c needs to start looking a lot
more like the st_cb_bitmap.c, if the draw-pixel-with-texture test is
correct, which I've no reason to believe it isn't.

Dave.


>
> Dave.