[Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

[Eric Anholt]

On Sat, 10 Dec 2011 12:00:27 -0700, Brian Paul <brianp at vmware.com> wrote:
> This fixes two things:
> 1. If the texture object was created with glTexStorage2D, the call
>    to _mesa_TexImage2D() would generate INVALID_OPERATION since the
>    texture is marked as immutable.
> 2. _mesa_TexImage2D() always frees any existing texture image memory
>    before allocating new memory.  That's inefficient since the existing
>    image is usually the right size already.

Actually, scratch that review.  I think I see a bug:
update_fbo_texture() is no longer called with this, so FBOs attached to
this texture may have incorrect FBO completeness after a GenerateMipmap.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111212/fc1f6333/attachment.pgp>